History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: XCF-2400
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Raghu Venkataramana
Reporter: Scott Lawrence
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
sipXconfig

MRTG integration overwrites and modifies configuration files invisible to rpm

Created: 2008-03-28 10:08   Updated: 2008-09-10 08:40
Component/s: install and upgrade
Affects Version/s: 3.10.1, 3.10.0
Fix Version/s: 3.11.6

Original Estimate: 2 days Remaining Estimate: 0 minutes Time Spent: 1 day
File Attachments: 1. Text File 0003-XCF-2400-first-proposal-this-patch-makes-the-mrt.patch (12 kb)

Issue Links:
Dependancy
 
This issue required for:
XECS-1316 Alerting email should be sent to syst... Minor Resolved
Duplicate
 
This issue also reported as:
XCF-2433 MRTG Host settings not retained after... Major Resolved
Related
This issue related to:
XCF-2348 Make the mrtg configuration specific ... Minor Resolved
This issue related to:
XCF-2397 upgrading sipx disables MRTG monitori... Major Closed


 Description  « Hide
The present method of configuring and initializing mrtg will cause problems with any upgrade.

The sipx-mrtg-init script is run from the sipXconfig spec file. It creates and modifies configuration files; this is an error-prone way to operate, and bypasses the protections and capabilities provided by the rpm system.

This needs to be revamped and done correctly using the capabilities of the rpm system correctly.


 All   Comments   Work Log   Change History      Sort Order:
Damian Krzeminski - 2008-03-28 10:12
Makes sense: sipxconfig-mrtg should use whatever capabilities are offered by RPM system. Installing files is better than modifying them. Part of the problem here is that sipx is hijacking MRTG configuration.

Damian Krzeminski - 2008-04-03 17:55
One of the user-visible effects of that is that every time MRTG is installed/upgraded it wipes out the previous configuration.

Martin Steinmann - 2008-05-31 07:32
Andrei - Would you mind having a look at this issue and XCF-2348, so that we can close this out? Thanks --martin

Andrei Niculae - 2008-07-01 12:48
This patch is on top of 0002-Put-mrtg-configuration-files-in-prefix-etc-sipxpbx.patch patch from XCF-2348 .
It puts the mrtg configuration files in the rpm, rather than being modified/created by the script.
In the rpm I also put the sipxconfig.properties.in file with the monitoringContextImpl.enabled set to true.
In this patch, the mrtg-init-script is almost useless, but it's still invoked upon uninstall.

About the snmp configuration file: As I have commented on XCF-1891, I'm currently investigating a way to make snmp managed by sipXsupervisor. If I succeed, then I will do the same thing I've done for mrtg configuration with snmp configuration.
But until then, hijacking the snmp configuration could be performed either by the sipx-snmp-init script, or in the same way as vsftpd is configured in sipxconfig.spec file. I'm thinking that these two ways are almost identical, but someone with more knowledge in rpm should give his opinion about this.

Damian Krzeminski - 2008-09-09 17:42
http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13366

XCF-2400 mrtg configuration is installed rather then modified by scripts

The sipx-mrtg-init script use is now limited to enabling and disabling mrtg context
(monitoringContextImpl.enabled property in sipxconfig.properties.in) and reconfiguring location or
mrtg binary.

(Same verification as XCF-2348)