[#XECS-1250] setup.d scripts are running every time you start the system

sipXecs

setup.d scripts are running every time you start the system

Created: 2008-03-21 15:59 Updated: 2008-11-12 00:54

Component/s:

sipXpbx

Affects Version/s:

None

Fix Version/s:

4.2

Original Estimate:	4 hours	Remaining Estimate:	4 hours	Time Spent:	Unknown
File Attachments:	1. 0001-XCF-1250-add-generic-mechanism-to-suppress-running-s.patch (6 kb)

Description

« Hide

I am pretty sure that the intent was that scripts in setup.d are supposed to be run only once after the installation or upgrade.
(At least judging by the contents of sipxcallresolver-setup)

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Damian Krzeminski - 2008-03-21 21:29

No need to fix it for 3.10. Running setup scripts is suboptimal, but unless we have scripts that really cannot be run multiple time not fixing it in 3.10 is a safer option than fixing it in 3.10.

[ Permlink | « Hide ]

Damian Krzeminski - 2008-03-27 13:33

See: http://thread.gmane.org/gmane.comp.voip.sipx.devel/7759
This actually suggest that setup.d scripts are executed every time and it's a script responsibility to discover if it's been run. No script is doing this discovery at the time: at the minimum we need a standard way of handling such situations.

[ Permlink | « Hide ]

Damian Krzeminski - 2008-03-28 16:52

Modify sipxpbx script (setup_modules function) to create a marker file if setup.d is run.
If marker file is present the script is not going to be run again (until marker file is removed).
If developer wants to re-enagle running the script package manager (RPM) needs to clean marker files.
Script needs to return a special error code (SIPX_SETUP_RUNONCE_EXIT by default 100) to be only run once.