|
Sort Order:
[
Permalink
| « Hide
]
Douglas Hubler added a comment - 2006-06-23 06:44
Cool feature
Assign this to Gibson for feature tracking.
Removed this from 3.6 list per Martin's email on 7/1/06.
Changed the UI.
See the thread about this : http://comments.gmane.org/gmane.comp.voip.sipx.devel/7843 The first patch for this issue. This is against an older revision, since it was ready before Easter, but I had some minor modifications to add to it. I see that there have been some changes with the restart mechanism. I'll post a patch against the newer revision soon.
I tried to rebase it but as you noticed Restart management was rewritten so there is not much that can be salvaged.
However I believe that it should be now easier to implement this feature (there is only a single restart manager not 3). Some comments: - the bulk of the implementation should end up in RestartManger and not in LazyRestartManger, lazy restart manager should just pass the call to real restart manager, there is no point in delaying the scheduled restart: you do not have to spin a new thread to schedule something - please do not use @SuppressWarnings - there are rare cases where it makes sense to use it, mostly if we want to preserve unused parameter, but in most cases we want to see and get rid of all warnings - please do not add comments in Romanian: it's a beautiful language alas not commonly known; we all agreed to just continue to butcher English another customer request for this functionality (there have been others, too):
salesforce case 4258, https://na4.salesforce.com/50060000004VZGu This is the patch that implements XCF-1098
It introduces a new TimerTask in RestartManagerImpl.java which triggers a restart at a specified time. It also introduces a new column to all the devices (phones, gateways, sbcDevices): information. This column displays the restart date. I've named this column information, because the restart date ends up in the database only after a profile is generated, so the user might have been confused if he scheduled a restart and the scheduled restart date didn't appear immediately. That's why I introduced a new class: DeviceStatus which keeps track whether or not a device is generating its profile. Also, now, when a profile is generated, a device cannot be deleted (this was a bug, I believe). This behavior can be extended so a device can report different statuses. Right now it only reports if it is generating its profile or not (updating). Please review. http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13264
XCF-1098 rewrite restart manager to handle scheduled restarts RestartManager interface now takes timestamp of the restart allowing for delayed restart. The implementation relies on ScheduledExecutorService from concurrent package. Throttling restarts is still supported (if you restart more than one device there is a minimum throttle period to separate http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev= persistent: if sipXconfig is closed or dies devices will not get restarted. This is not a new problem, but it may become more serious now that restarting can be delayed by more than just a couple of minutes. ------------------------------------------------------------------------ http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13265 XCF-1098 ProfileManager fixes to allow for delayed restart Profile Manager interface allows for specifying the restart timestamp. Profiles are still generated asynchronously, timestamp applies to restart only (so specifying restart in couple of days will not stop sipXconfig from pushing profile as soon as it has time to do that). The restart will always be scheduled *after* the profile is generated. ------------------------------------------------------------------------ http://sipxecs.sipfoundry.org/ViewVC/sipXecs?view=rev&rev=13266 XCF-1098 ConfirmProfileGeneration UI updated to allow for delaying device restart. This feature has been implemented and the devices indeed reboot after setting the schedule. Currently we have,
sipxpublisher 3.11.9-014409 2009-01-07T03:09:27 oem-centos5 sipxproxy 3.11.9-014409 2009-01-07T03:05:24 oem-centos5 Any bugs found will be reported separately. Hence this issue may be closed. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
New Feature
Closed
Major
Scheduled Device (phone, gateway) reboot from sipxconfig
