sipXecs

Primary Line credential becomes 'editable' after changing the domain name

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Rank:
    3638   
  • Labels:
  • Description:
    Hide
    This issue is being filed on behalf of Sathya Shankar

    After changing the domain name in sipXconfig, the primary line's credential becomes editable and allows you to change the credential details.

    Step to reproduce:
    1) First go to the Administration -> Settings and change the domain name.

    2) After that, for any user, click on the 'Lines' tab.

    Expected result:
    The credentials field should not have an edit icon next to it. (This is the default behavior)

    Actual result:
    The credentials field *does* have an edit icon and it can be edited.
    Show
    This issue is being filed on behalf of Sathya Shankar After changing the domain name in sipXconfig, the primary line's credential becomes editable and allows you to change the credential details. Step to reproduce: 1) First go to the Administration -> Settings and change the domain name. 2) After that, for any user, click on the 'Lines' tab. Expected result: The credentials field should not have an edit icon next to it. (This is the default behavior) Actual result: The credentials field *does* have an edit icon and it can be edited.
  • Environment:
    RHE - Minimal Configuration
    Sipx from beta distribution
  1. changein relam.jpg
    (31 kB)
    Raghu Venkataramana
    2004-12-27 12:45
  2. relam_changes.jpg
    (87 kB)
    Raghu Venkataramana
    2004-12-27 12:46

Activity

Hide
Damian Krzeminski added a comment - 2005-03-28 19:46
This is actually a slightly different issue than described:
- credentials for realms that are equal to sipX domain (sic!) are always read-only; credentials for other realm are always editable.
It does not matter if you change the domain name or not. What matters is if your realm is the same as your domain. If it is your credentials, are non-editable.

Until 2.6 domain and realm were used in sipX pretty much interchangeably: this is one of the cases where domain is used in the place where realm should be used.

We have 2 options:

(1) - compare credentials realm to sipX realm (and not to domain name) to determine if credentials are read-only
(2) - make all credentials, always editable - the consequence of that would be that if administrator modifies user's primary credentials, the Voicemail PIN will be changed, but the password that enables to log in into sipXconfig user portal will remain unchanged (I suppose the fact that primary line credential plays this double role is what prompted sipXconfig original authors to make it read-only)

I'll attempt to implement (1) since it's more in the spirit of current solution.
In future we need to support a clear separation between sip password and user pin (which hopefully also clarifies the lines credentials UI) and we will be able to enable editing for all credentials.
Show
Damian Krzeminski added a comment - 2005-03-28 19:46 This is actually a slightly different issue than described: - credentials for realms that are equal to sipX domain (sic!) are always read-only; credentials for other realm are always editable. It does not matter if you change the domain name or not. What matters is if your realm is the same as your domain. If it is your credentials, are non-editable. Until 2.6 domain and realm were used in sipX pretty much interchangeably: this is one of the cases where domain is used in the place where realm should be used. We have 2 options: (1) - compare credentials realm to sipX realm (and not to domain name) to determine if credentials are read-only (2) - make all credentials, always editable - the consequence of that would be that if administrator modifies user's primary credentials, the Voicemail PIN will be changed, but the password that enables to log in into sipXconfig user portal will remain unchanged (I suppose the fact that primary line credential plays this double role is what prompted sipXconfig original authors to make it read-only) I'll attempt to implement (1) since it's more in the spirit of current solution. In future we need to support a clear separation between sip password and user pin (which hopefully also clarifies the lines credentials UI) and we will be able to enable editing for all credentials.
Hide
Damian Krzeminski added a comment - 2005-03-28 20:22
properly identify "primary" credentials by comparing credentials' realm agains sipX's realm (and not against sipX's domain)

http://scm.sipfoundry.org/viewsvn/sipXconfig?view=rev&rev=695

Please note that nothing stops the user from adding multiple "primary" credentials (looks strange but should be harmless). This is however consistent with how it used to work before.
We will implement proper fix (making all credentials editable) after clearly separating sip password from user pin.
Show
Damian Krzeminski added a comment - 2005-03-28 20:22 properly identify "primary" credentials by comparing credentials' realm agains sipX's realm (and not against sipX's domain) http://scm.sipfoundry.org/viewsvn/sipXconfig?view=rev&rev=695 Please note that nothing stops the user from adding multiple "primary" credentials (looks strange but should be harmless). This is however consistent with how it used to work before. We will implement proper fix (making all credentials editable) after clearly separating sip password from user pin.
Hide
Raghu Venkataramana added a comment - 2005-04-12 12:11
Verified using sipxconfig 2.8.0 r000077 2005-04-08T20:24:35 vulture
Show
Raghu Venkataramana added a comment - 2005-04-12 12:11 Verified using sipxconfig 2.8.0 r000077 2005-04-08T20:24:35 vulture

People

Dates

  • Created:
    2004-12-28 03:44
    Updated:
    2009-04-24 21:05
    Resolved:
    2005-03-28 20:22